Hi,
Lukasz Majewski lukma@denx.de writes:
[snip]
I do appreciate that you tested it - even better, that with different approach.
However, some time ago Stephen Warren has rewritten tests for DFU, UMS to use some python infrastructure. Those tests (especially DFU, test corner cases - ZLP, +/-1B to packet size, etc).
that's exactly what I tested :-)
If you want, you can add your board to them.
I'll see how to do that and maybe add to the TODO list
Acked-by: Lukasz Majewski lukma@denx.de
Tested-by: Lukasz Majewski lukma@denx.de
Test HW: BBB (am335x) - with tests/py/dfu
I've added your patch to u-boot-dfu tree. I will send PR tomorrow.
yeah, cool thanks ;-)
You may also want to look into patches from Patrick Delaunay (those also will be added to PR):
http://patchwork.ozlabs.org/patch/704131/ http://patchwork.ozlabs.org/patch/706492/ http://patchwork.ozlabs.org/patch/706493/
they look fine to my eyes. I have two extra patches (coming shortly) to make USB Command Verifier tool (from USB-IF) happy with our DFU implementation.