On Thu, Dec 22, 2011 at 3:29 PM, Igor Grinberg grinberg@compulab.co.il wrote:
On 12/22/11 11:26, Govindraj wrote:
Hi Igor,
[...]
probably the right method to do is as we did for panda,
Add to armv7/omap3/clock.c (soc specific code) to enable usb-host clocks.
as done in below patch for omap4 socs.
Hmmm... I don't like that patch - this is the right method... but only for panda! For panda it makes sense to enable the USB related clocks by default because it has many of its boot important peripherals wired to USB. That is not the case with majority of OMAP3 (and I bet with many other OMAP4) boards. Therefore, I think the USB clocks need to be turned on only if the board requests them to be turned on and not as a part of the default clock initialization by the PRCM subsystem (unless it is configurable in the board config file).
okay, I thought nothing wrong in keeping them enabled by default. since all un-used clocks will be gated once kernel is loaded. Am I missing some thing here?
so as discussed earlier we can add ehci_omap3_clock_init into ehci-omap.c that can be used from all omap3 socs.
-- Thanks, Govindraj.R