Dear unsik Kim,
In message 57afda040902020032h760174adja5ecba853ef6863b@mail.gmail.com you wrote:
Hello?
I fixed and added followings for your requests.
too long line length => fixed
not a linux coding style => fixed
add document (doc/README.mflash)
ARM only dependency and always init problem => fixed
msecs_to_hz function is changed.
In some ARM platform, CONFIG_SYS_HZ is not 1000 (samsung s3c24xx, intel pxa25x, pxa27x) and get_timer() just return elapsed tick of OS timer. For the compatibility of these, I use #ifdef.
Any comments, advice will be appreciated.
Here is fixed patch.
unsik Kim
Signed-off-by: unsik Kim donari75@gmail.com
common/Makefile | 2 + common/cmd_mgdisk.c | 76 ++++++ common/cmd_nvedit.c | 8 +- common/env_mgdisk.c | 90 ++++++ disk/part.c | 8 +- disk/part_amiga.c | 5 +- disk/part_dos.c | 1 + disk/part_efi.c | 1 + disk/part_iso.c | 1 + disk/part_mac.c | 1 + doc/README.mflash | 93 +++++++ drivers/block/Makefile | 5 +- drivers/block/mg_disk.c | 629 +++++++++++++++++++++++++++++++++++++++++++ drivers/block/mg_disk_prv.h | 140 ++++++++++ fs/fat/fat.c | 2 + include/config_cmd_all.h | 1 + include/environment.h | 12 + include/mg_disk.h | 51 ++++ include/part.h | 1 + 19 files changed, 1119 insertions(+), 8 deletions(-)
Sorry, in the mean time this commit has been checked in:
commit 2fb2604d5c20beb061b0a94282b7f6eb14d00cb8 Author: Peter Tyser ptyser@xes-inc.com Date: Tue Jan 27 18:03:12 2009 -0600
Command usage cleanup
Can you please rebase and resubmit your patch? Thanks.
Best regards,
Wolfgang Denk