Hi Stephen,
On Mon, 2 Dec 2019 at 09:04, Stephen Warren swarren@wwwdotorg.org wrote:
On 12/1/19 7:34 PM, Simon Glass wrote:
Buildman doesn't store this file in the same directory as a normal build. Update the conftest code to handle both cases.
Shouldn't we just fix buildman so that it puts the files in the standard locations? That way, we don't have to separately update every tool that might want to find/interpret this file or archive the build results, but instead just update one tool (buildman).
Well we could, but IMO it is better to separate the build process from the output process. With buildman the outputs end up all in the same directory (including spl, for example). I think it becomes confusing if we just leave files where the build system happens to leave them, even worse if we wanted to keep files in include/generated. Also, those locations might change in future.
It is certainly good to have pytests run on a build without preprocessing, though.
Regards, Simon