Re: [U-Boot] [RESEND PATCH 3/5] usb: host: dwc2: force reset assert

On 11/6/19 7:27 PM, Patrick DELAUNAY wrote:

Hi,

Hi,

[...]

...

...

diff --git a/drivers/usb/host/dwc2.c b/drivers/usb/host/dwc2.c index 51023b0c2c..3086411fc4 100644 --- a/drivers/usb/host/dwc2.c +++ b/drivers/usb/host/dwc2.c @@ -1149,6 +1149,8 @@ static int dwc2_reset(struct udevice *dev) return ret; }

• reset_assert_bulk(&priv->resets);
• udelay(2);

Why is there a 2 uS delay ?

I think: no real reason to have 2 us....

It was jus a reasonable time to be sure that the device reset is correctly performed, the reset signal is propagated....

but perhaps that no delay is working... I can test without delay if you prefer...

PS: I use the same value than DWC2 gadget driver: Added by my commit c2c74f97afff

Isn't there a way to poll the IP to determine whether the reset completed ?

[...]