Hi Scott,
Thanks for your review.
On Mon, 2016-01-18 at 12:27 +0800, Dongsheng Wang wrote:
+#ifdef CONFIG_ARMV7_PSCI_GTE_1_0
- tmp = fdt_psci_gte_1_0_fixup(fdt, nodeoff); if (tmp) return tmp;
- tmp = fdt_setprop_u32(fdt, nodeoff, "migrate", PSCI_FN_MIGRATE);
+#endif
- tmp = fdt_psci_0_1_fixup(fdt, nodeoff);
The "gte" is needless verbosity and is inconsistent with "fdt_psci_0_1_fixup" which lacks it.
Yes, fdt_psci_1_0_fixup is better.
Another idea, maybe we should need to put the compatible fixup code into platform code. Because we cannot mandatory fix the compatible for all of platform, and If we support the follow-up version we don't need to put all of version into the compatible. The version used on platform should depend on platform code. We can provide a default version, but not mandatory for all of platform.
__weak int psci_compatible_fixup(void *fdt, int nodeoff) { ... ... }
static int fdt_psci(void *fdt) { ... ... psci_compatible_fixup(fdt, nodeoff); ... }
Regards, -Dongsheng