On Wed, Oct 9, 2024 at 4:27 AM Peng Fan (OSS) peng.fan@oss.nxp.com wrote:
+&usdhc2 {
bootph-pre-ram;bootph-some-ram;fsl,signal-voltage-switch-extra-delay-ms = <8>;
Why is 'fsl,signal-voltage-switch-extra-delay-ms' a U-Boot-only property?
How does kernel handle usdhc2 without this property?
+#include <usb.h> +#include <dwc3-uboot.h>
I don't see USB support in this file.
+DECLARE_GLOBAL_DATA_PTR;
+#define UART_PAD_CTRL (PAD_CTL_DSE(6) | PAD_CTL_FSEL2) +#define WDOG_PAD_CTRL (PAD_CTL_DSE(6) | PAD_CTL_ODE | PAD_CTL_PUE | PAD_CTL_PE)
+static iomux_v3_cfg_t const uart_pads[] = {
MX93_PAD_UART1_RXD__LPUART1_RX | MUX_PAD_CTRL(UART_PAD_CTRL),MX93_PAD_UART1_TXD__LPUART1_TX | MUX_PAD_CTRL(UART_PAD_CTRL),+};
+int board_early_init_f(void) +{
imx_iomux_v3_setup_multiple_pads(uart_pads, ARRAY_SIZE(uart_pads));
With DM_SERIAL, there is no need for UART board code and watchdog IOMUX settings.
+int board_phy_config(struct phy_device *phydev) +{
if (phydev->drv->config)phydev->drv->config(phydev);
Is this really needed?
val = ret;if (is_voltage_mode(VOLT_LOW_DRIVE)) {buck_val = 0x0c; /* 0.8v for Low drive mode */
The unit for Volt is V with a capital letter. Please fix it globally.
+.. SPDX-License-Identifier: GPL-2.0+
+imx93_9x9_qsb +=======================
+U-Boot for the NXP i.MX93 Quick Starter Board
In the commit log you put "Quick Start". Please be consistent.
+Build U-Boot +------------
+.. code-block:: bash
- $ export CROSS_COMPILE=aarch64-poky-linux-
- $ make imx93_9x9_qsb_defconfig
Please also explain when imx93_9x9_qsb_inline_ecc_defconfig could be used, the difference between the two defconfigs, etc.
+config IMX9_DRAM_INLINE_ECC
bool "Enable DDR INLINE ECC feature"default n
default n is already the default. Just remove it.
+/* Initial environment variables */ +#define CFG_EXTRA_ENV_SETTINGS \
BOOTENV \"prepare_mcore=setenv mcore_clk clk-imx93.mcore_booted;\0" \"scriptaddr=0x83500000\0" \"kernel_addr_r=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \"image=Image\0" \
Please move it to a .env file instead.