Re: [U-Boot] [PATCH v2 0/7] FPGA cleanup + zynq support

On 05/01/2013 05:14 PM, Tom Rini wrote:

On Wed, May 01, 2013 at 10:59:16AM +0200, Michal Simek wrote:

...

Fpga code is pretty old and none has tried to clean it up. My attempt is related to new code I want to push to mainline which is add support for checking bitstream and if bitstream is valid for the selected device. For this I need to do cleanup code and move code from cmd_fpga.c to fpga.c in driver folder.

Aside from my comments to 4/7, everything else looks good and a step forward.

ok

Looking at 7/7 however, it seems like:

• None of CONFIG_SYS_XILINX_IF_* are used
• CONFIG_SYS_... model definitions... aren't used, now that CONFIG_FPGA isn't a bitfield anymore, and are only used by configs that still act like it is.

So we could just clean up and remove those parts of the header, yes?

yep, you are right. I will create one more patch which remove these values. (It should be done in 2008).

Thanks, Michal