
On 02/13/2013 02:44 PM, Tom Warren wrote:
Linux dts files were used for those boards that didn't already have sdhci info populated. Tamonten has their own dtsi file with common sdhci nodes (sourced from Linux).
diff --git a/dts/Makefile b/dts/Makefile index 922c78c..2ef31e9 100644 --- a/dts/Makefile +++ b/dts/Makefile @@ -50,7 +50,7 @@ DT_BIN := $(obj)dt.dtb $(DT_BIN): $(TOPDIR)/board/$(VENDOR)/dts/$(DEVICE_TREE).dts rc=$$( \ cat $< | $(CPP) -P $(DTS_CPPFLAGS) - | \
{ { $(DTC) -R 4 -p 0x1000 -O dtb -o ${DT_BIN} - 2>&1 ; \
echo $$? >&3 ; } | \ grep -v '^DTC: dts->dtb on file' ; \ } 3>&1 1>&2 ) ; \{ { $(DTC) -R 4 -p 0x1000 -i $(TOPDIR)/board/$(VENDOR)/dts -i $(TOPDIR)/arch/$(ARCH)/dts -O dtb -o ${DT_BIN} - 2>&1 ; \
Shouldn't this be a separate patch?
The one issue with this is that only newer versions of dtc support the -i option. The version packaged with most distros won't support it. That'll mean something like "MAKEALL -a arm" is going to fail for a lot of people without some kind of explicit action (i.e. manually installing a newer version of dtc).
That's why I suggested switching from /include/ to #include, and adding the include path to the cpp command rather than dtc.