On 27.06.18 19:07, Tom Rini wrote:
On Wed, Jun 27, 2018 at 06:45:39PM +0200, Alexander Graf wrote:
On 06/26/2018 08:57 PM, andrew thomas wrote:
On 06/26/2018 05:34 AM, Alexander Graf wrote:
On 06/21/2018 10:37 AM, Peter Robinson wrote:
On Mon, Jun 18, 2018 at 7:56 PM, Andrew Thomas andrew.thomas@oracle.com wrote:
This bug is the combination of dwc2 USB controller and lan78xx USB ethernet controller, which is the combination in use on the Raspberry Pi Model 3 B+.
When the host attempts to receive a packet, but a packet has not arrived, the lan78xx controller responds by setting BIR (Bulk-In Empty Response) to NAK. Unfortunately, this hangs the USB controller and requires the USB controller to be reset.
The fix proposed is to have the lan78xx controller respond by setting BIR to ZLP.
Signed-off-by: Andrew Thomas andrew.thomas@oracle.com
Tested-by: Peter Robinson pbrobinson@gmail.com
Tested on the RPi 3B+ and certainly improves this situation a number of Fedora users have seen.
What exactly have you tested?
Even with this patch, I am not reliably to reliably boot into grub.
Can you say which version of grub?
I actually see the same effect on an old RPi3 B, so it's not lan7x specific. We also have the exact same fix for the old 100Mbit/s LAN adapter, so I think this fix is certainly moving us into the right direction.
Reviewed-by: Alexander Graf agraf@suse.de
Tom, can you please pull it in for 2018.07 still?
Do you have anything else Pi-related to go in? If not, I'll grab it directly, otherwise send me a PR, thanks!
It's the only patch I'd have left for this release. Please just apply it directly.
Thanks!
Alex