On Fri, 26 Jan 2007 10:46:54 +0100 Wolfgang Denk wd@denx.de wrote:
In message BB798853-8000-4747-A6BD-26E5E71AD80B@kernel.crashing.org you wrote:
Since they are different physical boards they should have different <config>.h, that rule's been pretty standard in u-boot.
No, not at all. We have many similar boards share one configuration file - especially in the case of modules that can be used on different carrier boards.
I didn't see any that had the same config behaviour as this patch does (ifdeffing itself). In any case, the ITX and ITX-GP do not have any modular properties. Plus, there are more similarly 'fixed' boards coming that are similar, but in different ways, to the ITX and the ITX-GP.
My reluctance is stemmed from the prediction of the growing number of ifdefs in the config file. Perhaps the best thing to do here is have the main config file have a single set of ifdefs for each individual board, and include that board's delta config from a sub-board config file. All common elements remain in the main config file, and if a board define is not matched, #error out.
Kim