Hi Tom
thanks for your feedback.
Am 16.01.2010 20:18, schrieb Tom:
+/*
- Miscellaneous platform dependent initialisations
- */
+int board_init(void) +{
board_init should fill out entries in struct global_data. See other board like lopgicpd/zoom1 as an example. Make sure to include the machine id.
As I don't use Linux on this board I don't have such an id. How to deal with such a situation? Should I get a machine id anyway? And if so can you give me a hint on how I can get such an id?
- /*
* (4) IRESET/IUSRRST release- /*
This looks like a programming error /* -> */ ?
You are right. Thanks for catching this.
+#define CONFIG_JADE
The board and cpu defines go first move the device configs to later
Can you please explain what you mean with this comment?
+#define CONFIG_JADE_IOCLK (41164767)
This is a strange number. please add a comment.
Well, it is the clock frequency of the IO blocks of the SoC. Its 14,31818 MHz * 46 / 16. I added a comment.
I have fixed the other stuff you pointed out.
Regards, Matthias