Re: [PATCH v5 2/8] net: dsa: move cpu port probe to dsa_post_probe

On Tue, Oct 04, 2022 at 09:49:12AM -0700, Tim Harvey wrote:

diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index 5b7046432ff3..a37e76e25a8f 100644 --- a/net/dsa-uclass.c +++ b/net/dsa-uclass.c @@ -466,7 +466,6 @@ static int dsa_pre_probe(struct udevice *dev) +static int dsa_post_probe(struct udevice *dev) +{

• struct dsa_priv *priv = dev_get_uclass_priv(dev);
• struct dsa_ops *ops = dsa_get_ops(dev);
• int err;
• /* Simulate a probing event for the CPU port */ if (ops->port_probe) { err = ops->port_probe(dev, priv->cpu_port,

@@ -491,13 +499,14 @@ static int dsa_pre_probe(struct udevice *dev) }

return 0; -} +};

Semicolons aren't needed at the end of functions.