Re: [U-Boot] [PATCH] da8xx: add support for multiple PLL controllers

Hi,

[...]

• pre_div = (readl(&davinci_pllc_regs->prediv) &

•    DAVINCI_PLLC_DIV_MASK) + 1;
  

• pllm = readl(&davinci_pllc_regs->pllm) + 1;

• pre_div = (REG(pll_base + PLLC_PREDIV) & 0xff) + 1;
• pllm = REG(pll_base + PLLC_PLLM) + 1;

Nack - do not change "common" accessors into local macros. We should really strive to have a common base here. See also

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/104428

Cheers Detlev