1 Feb
2016
1 Feb
'16
5:54 p.m.
On Sat, Jan 30, 2016 at 03:45:16PM -0700, Simon Glass wrote:
Using short doesn't save anything and is confusing when the width and height variables are ulong.
This may fix Coverity CID134902 but I doubt it.
It won't, that CID wants height to be sanity checked as it comes from an external source and we don't make sure it has a valid value, as far as coverity thinks at least. If you're happy with: if ((x + width) > pwidth) width = pwidth - x; if ((y + height) > priv->ysize) height = priv->ysize - y;
Being sufficient sanity checking on both, I can close the defect out as a false positive. Thanks!
Signed-off-by: Simon Glass sjg@chromium.org
Reviewed-by: Tom Rini trini@konsulko.com
--
Tom