On Thu, 20 Aug 2009 20:20:08 -0700 Prafulla Wadaskar prafulla@marvell.com wrote:
+#define KIRKWOOD_PHY_ADR_REQUEST 0xee
define this in header file
Basically this is needed in drivers/net/phy/mv88e61xx.c for
multi chip support
in this case we need to define this in include/miiphy.h. which conflicts with other phy address definition, that's
why not done earlier
It makes more sense to add APIs miiphy_read/write_phyadr to miiutils
But is this really general functionality? miiphy.h is something I suppose should be generic between phys and not contain device-specific things like this.
Agreed, Current PHY support need to be re-architected to support switches in generic ways This is old pending issue, may be we should re-trigger it again after scheduled release
Right. But for now, perhaps it's OK to merge the patch as-is and then correct the location of the define when the restructuring is done?
In the same way, I guess we should postspone moving out PHY initialization from sheevaplug and keep it duplicated until it's clear what to do there?
// Simon