On Tue, Sep 04, 2018 at 12:57:54PM +0200, Alexander Graf wrote:
Am 04.09.2018 um 12:50 schrieb Heinrich Schuchardt xypron.glpk@gmx.de:
On 09/04/2018 11:01 AM, Alexander Graf wrote:
On 04.09.18 09:49, AKASHI Takahiro wrote: Directory iterator was introduced in major re-work of read operation by Rob. We want to use it for write operation extensively as well.
Please indicate in the commit message that write operations are implemented in a different .c file and so we have to export the respective functions.
Why? Look at this ugly code:
fs/fat/fat_write.c:17:#include "fat.c"
In that case we don't need this patch at all, no?
Oops, I didn't notice this before. If, however, "include fat.c" makes any sense, theoretically we don't need "depends on FS_FAT" for FS_FAT_WRITE. There seems to be a contradiction between the code and config.
I prefer just to remove the line, '#include "fat.c"' from fat_write.c and add more "extern" definitions in fat.h if necessary.
Thanks, -Takakahiro AKASHI
Alex
Best regards
Heinrich
Alex