Hi Peter,
On 20 June 2017 at 17:02, Peter Robinson pbrobinson@gmail.com wrote:
On 20 June 2017 at 05:19, Tom Rini trini@konsulko.com wrote:
On Tue, Jun 20, 2017 at 11:15:19AM +0100, Peter Robinson wrote:
On Tue, Jun 20, 2017 at 1:47 AM, Tom Rini trini@konsulko.com wrote:
Hey all,
It's release day and v2017.07-rc2 is out. I'm mostly happy with the size of the changes here and I did remember to sync the defconfigs prior to tagging.
If anyone has critical fixes I've missed or some Kconfig migrations (that I can prove out as correct), please speak up.
Things look on track for -rc3 on July 3rd and release on July 10th. Thanks all!
I'm seeing failures/regression in this cycle (both RC1 and RC2) building a lot of the boards, I suspect this is a difference between using upstream (with python support patches) dtc vs the in-tree one. We use the upstream one to ensure we get consistency across all dtc consumers so it would be nice to have the same functionality as prior releases.
Peter
gcc -Wp,-MD,spl/drivers/mmc/.sunxi_mmc.o.d -nostdinc -isystem /usr/lib/gcc/armv7hl-redhat-linux-gnueabi/7/include -Iinclude -I/builddir/build/BUILD/u-boot-2017.07-rc2/include -I/builddir/build/BUILD/u-boot-2017.07-rc2/arch/arm/include -include /builddir/build/BUILD/u-boot-2017.07-rc2/include/linux/kconfig.h -I/builddir/build/BUILD/u-boot-2017.07-rc2/spl/drivers/mmc -Ispl/drivers/mmc -D__KERNEL__ -D__UBOOT__ -DCONFIG_SPL_BUILD -Wall -Wstrict-prototypes -Wno-format-security -fno-builtin -ffreestanding -Os -fno-stack-protector -fno-delete-null-pointer-checks -g -fstack-usage -Wno-format-nonliteral -Werror=date-time -ffunction-sections -fdata-sections -D__ARM__ -Wa,-mimplicit-it=always -mthumb -mthumb-interwork -mabi=aapcs-linux -mno-unaligned-access -ffunction-sections -fdata-sections -fno-common -ffixed-r9 -msoft-float -pipe -march=armv7-a -D__LINUX_ARM_ARCH__=7 -I/builddir/build/BUILD/u-boot-2017.07-rc2/arch/arm/mach-sunxi/include -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(sunxi_mmc)" -D"KBUILD_MODNAME=KBUILD_STR(sunxi_mmc)" -c -o spl/drivers/mmc/sunxi_mmc.o /builddir/build/BUILD/u-boot-2017.07-rc2/drivers/mmc/sunxi_mmc.c ld.bfd -r -o spl/drivers/serial/built-in.o spl/drivers/serial/serial.o spl/drivers/serial/serial_ns16550.o spl/drivers/serial/ns16550.o ld.bfd -r -o spl/drivers/mmc/built-in.o spl/drivers/mmc/mmc.o spl/drivers/mmc/mmc_legacy.o spl/drivers/mmc/sunxi_mmc.o ld.bfd -r -o spl/drivers/built-in.o spl/drivers/i2c/built-in.o spl/drivers/gpio/built-in.o spl/drivers/mmc/built-in.o spl/drivers/serial/built-in.o spl/drivers/power/built-in.o spl/drivers/power/pmic/built-in.o spl/drivers/power/regulator/built-in.o spl/drivers/block/built-in.o (cd spl && ld.bfd -T u-boot-spl.lds --gc-sections -Bstatic --gc-sections --no-dynamic-linker -Ttext 0x60 arch/arm/cpu/armv7/start.o --start-group arch/arm/mach-sunxi/built-in.o arch/arm/cpu/armv7/built-in.o arch/arm/cpu/built-in.o arch/arm/lib/built-in.o board/sunxi/built-in.o common/spl/built-in.o common/init/built-in.o common/built-in.o cmd/built-in.o lib/built-in.o disk/built-in.o drivers/built-in.o dts/built-in.o fs/built-in.o --end-group arch/arm/lib/eabi_compat.o arch/arm/lib/lib.a -Map u-boot-spl.map -o u-boot-spl) objcopy -j .text -j .secure_text -j .secure_data -j .rodata -j .hash -j .data -j .got -j .got.plt -j .u_boot_list -j .rel.dyn -j .dtb.init.rodata -j .efi_runtime -j .efi_runtime_rel -O binary spl/u-boot-spl spl/u-boot-spl-nodtb.bin cp spl/u-boot-spl-nodtb.bin spl/u-boot-spl.bin ./tools/mksunxiboot --default-dt "sun4i-a10-olinuxino-lime" spl/u-boot-spl.bin spl/sunxi-spl.bin /builddir/build/BUILD/u-boot-2017.07-rc2/tools/binman/binman -d u-boot.dtb -O . -I . -I /builddir/build/BUILD/u-boot-2017.07-rc2/board/sunxi spl/sunxi-spl.bin Traceback (most recent call last): File "/builddir/build/BUILD/u-boot-2017.07-rc2/tools/binman/binman", line 32, in <module> import control File "/builddir/build/BUILD/u-boot-2017.07-rc2/tools/binman/control.py", line 15, in <module> import fdt File "/builddir/build/BUILD/u-boot-2017.07-rc2/tools/binman/../dtoc/fdt.py", line 13, in <module> import libfdt File "tools/libfdt.py", line 612, in <module> FDT_ERR_TOODEEP = _libfdt.FDT_ERR_TOODEEP AttributeError: 'module' object has no attribute 'FDT_ERR_TOODEEP' make[1]: *** [/builddir/build/BUILD/u-boot-2017.07-rc2/Makefile:1130: u-boot-sunxi-with-spl.bin] Error 1
Simon, do you have some suggestions on what to do here? Thanks!
-- Tom
My guess is that there is already a libfdt.py in the system. Someone else reported this too.
We could perhaps change the ordering in PYTHONPATH so that our one is first.
No, I'm not sure that's completely the case because I first saw a related issue before my dtc had the python patch set added to it, I would actually prefer to build with the distro dtc rather than a fork of upstream like we use to.
OK I think I see what is happening then. It seems to be picking up _libfdt.so from your system and libfdy.py from U-Boot. If so that seems like a bad idea at the best of times.
Despite upstreaming efforts we still have local libfdt changes in U-Boot. The main one is fdtgrep. I did try to upstream it a while back but failed. I've been thinking of trying again but have not mustered the energy.
This particular error could probably be worked around in the short term by dropping FDT_ERR_TOODEEP. But do we really want to allow this sort of thing? I think we should either use one libfdt module or the other, not a mixture of the two
Regards, Simon