Re: [PATCH 03/22] sunxi: Add missing dependencies to Kconfig selections

11 Nov 2022

On Tue,  1 Nov 2022 00:08:15 -0500
Samuel Holland samuel@sholland.org wrote:
...
Some of the selected symbols have a user-visible dependency. Make the
selections conditional on that dependency to avoid creating invalid
configurations.
No change in any of the generated configs, so looks fine:
...
Signed-off-by: Samuel Holland samuel@sholland.org
Reviewed-by: Andre Przywara andre.przywara@arm.com
Thanks,
Andre
...

arch/arm/Kconfig | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 939f76867e..4e5daa9e7f 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1134,30 +1134,30 @@ config ARCH_SOCFPGA
 config ARCH_SUNXI
   bool "Support sunxi (Allwinner) SoCs"
   select BINMAN

select CMD_GPIO


select CMD_GPIO if GPIO
select CMD_MMC if MMC
select CMD_USB if DISTRO_DEFAULTS && USB_HOST
select CLK
select DM


select DM_ETH
select DM_GPIO


select DM_ETH if NET
select DM_GPIO if GPIO
select DM_I2C if I2C
select DM_SCSI if BLK && SCSI
select DM_SERIAL if SERIAL
select DM_SPI if SPI
select DM_SPI_FLASH if SPI


select DM_SCSI if SCSI
select DM_SERIAL
select GPIO_EXTRA_HEADER
select OF_BOARD_SETUP
select OF_CONTROL
select OF_SEPARATE
select PINCTRL
select SPECIFY_CONSOLE_INDEX


select SPECIFY_CONSOLE_INDEX if SERIAL
select SPL_SEPARATE_BSS if SPL
select SPL_STACK_R if SPL
select SPL_SYS_MALLOC_SIMPLE if SPL
select SPL_SYS_THUMB_BUILD if !ARM64


select SUNXI_GPIO
select SYS_NS16550


select SUNXI_GPIO if GPIO
select SYS_NS16550 if SERIAL
select SYS_THUMB_BUILD if !ARM64
select USB if DISTRO_DEFAULTS
select USB_KEYBOARD if DISTRO_DEFAULTS && USB_HOST


    