Dear "kevin.morfitt@fearnside-systems.co.uk",
In message 4B2548EB.4000102@fearnside-systems.co.uk you wrote:
Cleans up the s3c24x0 header files by changing the upper case members of the s3c24x0 register structures to lower case and changing all code that uses these register structures.
Signed-off-by: Kevin Morfitt kevin.morfitt@fearnside-systems.co.uk
Thanks for doing such cleanup.
The patches are based on the u-boot-samsung repository.
Please adhere to posting guidelines. Patches posted ere MUST be based either on the "master" or on the "next" trees.
Please considered these patches NAKed because of this.
...
--- a/cpu/arm920t/s3c24x0/usb_ohci.c +++ b/cpu/arm920t/s3c24x0/usb_ohci.c @@ -212,8 +212,8 @@ void ep_print_int_eds(struct ohci *ohci, char *str) printf(__FILE__ ": %s branch int %2d(%2x):", str, i, i); while (*ed_p != 0 && j--) { struct ed *ed = (struct ed *) m32_swap(ed_p);
printf(" ed: %4x;", ed->hwINFO);ed_p = &ed->hwNextED;
printf(" ed: %4x;", ed->hwinfo);ed_p = &ed->hwnexted;
Her readability suffers a lot. What is "hwnexted" ??It might make sense to add some underscores here to improve readability - or chose better variable names.
dbg("%08x", edp->hwINFO);dbg("%08x", edp->hwTailP);dbg("%08x", edp->hwHeadP);dbg("%08x", edp->hwNextED);
dbg("%08x", edp->hwinfo);dbg("%08x", edp->hwtailp);dbg("%08x", edp->hwheadp);dbg("%08x", edp->hwnexted);
Ditto. Please check globally.
Best regards,
Wolfgang Denk