"George G. Davis" davis_g@comcast.net schreibt:
Anders Larsen wrote:
the tags are standard, but by nature the information is board-specific, so I don't see how lib_arm/armlinux.c could do much more than simply calling a function from the board tree. Do you think my idea of adding the hook setup_custom_tags() is _too_ generic?
Perhaps we can use environment variables to initialise those common tags in armlinux.c. Those environment variable can then be uniquely initialised/defined in whatever way makes sense for a given target port?
Another solution could be to add two fields to struct bd_info, e.g. bi_sernum and bi_revision, possibly "protected" by #ifdef CONFIG_SERNUM_TAG and #ifdef CONFIG_REVISION_TAG (bi_sernum is already defined similarly for at least the NX823), and have armlinux pass those to the kernel. The board-specific code would be responsible for filling those fields
This is arguably a cleaner solution than my generic hook.
Wolfgang, what do you think?
Cheers Anders