Re: [PATCH] board: stm32mp1: add splash screen on dk2

Hi all,

On Tue, Jul 4, 2023 at 10:11 AM Grzegorz Szymaszek gszymaszek@short.pl wrote:

Hi,

On Mon, Jul 03, 2023 at 06:27:54PM +0200, Dario Binacchi wrote:

...

diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c -%<- #include <syscon.h> +#include <splash.h> +#include <st_logo_data.h> #include <usb.h>

These two should be put above syscon.h if you want to keep the includes sorted alphabetically.

yes, you are right. I will update in v2

...

•                 ulong logo =
  

•                         (ulong)stmicroelectronics_uboot_logo_8bit_rle;
  

•                 bmp_display(logo, BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);
  

Technically logo is const.

int bmp_display(ulong addr, int x, int y); And throughout the code, I only find ulong parameters being passed to this function. Perhaps I can replace "logo" with "addr".

Thanks and regards, Dario

All the best

-- Grzegorz