
14 Oct
2008
14 Oct
'08
6:25 p.m.
Dear Heiko,
In message 48E08A58.5060000@denx.de you wrote:
Signed-off-by: Heiko Schocher hs@denx.de
drivers/i2c/soft_i2c.c | 24 ++++++++++++------------
...
+#if defined(CONFIG_8xx) && !defined(CONFIG_MGSUVD) volatile immap_t *immr = (immap_t *)CFG_IMMR; #endif
I cannot find any feedback from you fro my comment about this non-coding style change. We don't want to add such board specific code in global files.
Can you please update and resubmit this patch? Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Es gibt immer genug fuer die Beduerfnisse aller, aber niemals genug
fuer die Gier einzelner. -- Ghandi