
Hi Lukasz,
On Sun, May 6, 2018 at 5:26 PM, Lukasz Majewski lukma@denx.de wrote:
diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts index 1fb8225fbb..b187b6fac1 100644 --- a/arch/sandbox/dts/sandbox.dts +++ b/arch/sandbox/dts/sandbox.dts @@ -115,6 +115,10 @@ sandbox_pmic: sandbox_pmic { reg = <0x40>; };
mc34708_pmic: mc34708_pmic {
reg = <0x41>;
};
I know you are following the current style of this file, but this looks incorrect.
According to Devicetree Specification v0.2 document:
"The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model."
Also, the reg property needs to have a corresponding unit address.
It would better to rewrite this as:
mc34708: pmic@41 { reg = <0x41> };