Dear Wolfgang and Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 19:55 Thu 12 Feb , Dirk Behme wrote:
Add serial number based on OMAP3 die ID.
Signed-off-by: Dirk Behme dirk.behme@googlemail.com
Changes in v2:
- Rename 'serial' to 'serial#'
- Don't copy from a memory to an other, instead just update the pointer
board/omap3/beagle/beagle.c | 2 ++ board/omap3/evm/evm.c | 2 ++ board/omap3/overo/overo.c | 2 ++ board/omap3/pandora/pandora.c | 2 ++ board/omap3/zoom1/zoom1.c | 1 + cpu/arm_cortexa8/omap3/sys_info.c | 26 ++++++++++++++++++++++++++ include/asm-arm/arch-omap3/cpu.h | 13 +++++++++++++ include/asm-arm/arch-omap3/omap3.h | 1 + include/asm-arm/arch-omap3/sys_proto.h | 1 + 9 files changed, 50 insertions(+)
report it as the CPU serial if you want but report it as the board serial make no sense to me
While discussing about this, please consider arguments/point of view given in
http://lists.denx.de/pipermail/u-boot/2009-February/047458.html
too.
Additionally, looking at description of "serial#" at
http://www.denx.de/wiki/DULG/UBootEnvVariables
I understand:
-> "serial#: contains hardware identification information such as type string and/or serial number."
With OMAP3 == hardware this is true for OMAP3 device ID, no?
-> "This variable can be set only once (usually during manufacturing of the board)."
This is true if OMAP3 is never exchanged as assumption in my comment
http://lists.denx.de/pipermail/u-boot/2009-February/047458.html
no?
Regards
Dirk
Btw.: I haven't got the point why the string 'serial#' applies only to a _board_ serial number, yet?