Re: [U-Boot] [PATCH 3/4] common/lcd_console: move single static variables into common (static) structure

Nikita Kiryanov nikita@compulab.co.il schrieb am 15.03.2015 19:57:08:

Hi Hannes,

Hi Nikita,

...

-static void *lcd_console_address; +struct console_t {

• short curr_col, curr_row;
• short cols, rows;
• void *lcd_address;

Can this be void *base_address? I think that's a bit more descriptive.

Yes, i will do some cleanup after Patch 4/4 is finished and within this action i will rename this variable to fbbase - this should be most descriptive.

Other than that, Acked-by: Nikita Kiryanov nikita@compulab.co.il

...

+};

-- Regards, Nikita Kiryanov

many thanks and best regards, Hannes