On Mon, 14 Nov 2016 11:56:50 -0500 Tom Rini trini@konsulko.com wrote:
On Mon, Nov 14, 2016 at 04:47:26PM +0000, Andre Przywara wrote:
Hi,
On 14/11/16 16:30, Jagan Teki wrote:
On Thu, Nov 3, 2016 at 6:28 AM, Andre Przywara andre.przywara@arm.com wrote:
Somehow an int returning function without a return statement sneaked in. Fix it.
Signed-off-by: Andre Przywara andre.przywara@arm.com
drivers/mtd/spi/sunxi_spi_spl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi/sunxi_spi_spl.c b/drivers/mtd/spi/sunxi_spi_spl.c index 67c7edd..7502314 100644 --- a/drivers/mtd/spi/sunxi_spi_spl.c +++ b/drivers/mtd/spi/sunxi_spi_spl.c @@ -158,9 +158,10 @@ static void spi0_disable_clock(void) (1 << AHB_RESET_SPI0_SHIFT)); }
-static int spi0_init(void) +static void spi0_init(void) { unsigned int pin_function = SUNXI_GPC_SPI0;
Space not needed or unrelated, please remove this.
This is Linux coding style, which U-Boot adheres to. "WARNING: Missing a blank line after declarations"
I thought I should fix this since this is was in the context of this very simple patch and it improves readability. If this is too much, then please remove the line before committing.
Making things checkpatch clean is good, in the future please also mention that in commit messages. Thanks!
How can I get this checkpatch warning?
$ scripts/checkpatch.pl 0001-sunxi-Support-booting-from-SPI-flash.patch total: 0 errors, 0 warnings, 0 checks, 361 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
0001-sunxi-Support-booting-from-SPI-flash.patch has no obvious style problems and is ready for submission.