Haavard Skinnemoen wrote:
The information displayed when CONFIG_LCD_INFO is set is inherently board-specific, so it should be done by the board code. The current code dealing with this only handles two cases, and is already a horrible mess of #ifdeffery.
Yes, this duplicates some code, but it also allows boards to print more board-specific information; this used to be very difficult.
Signed-off-by: Haavard Skinnemoen haavard.skinnemoen@atmel.com
board/atmel/at91cap9adk/at91cap9adk.c | 29 ++++++++++ board/atmel/at91sam9261ek/at91sam9261ek.c | 29 ++++++++++ board/atmel/at91sam9263ek/at91sam9263ek.c | 29 ++++++++++ board/atmel/at91sam9rlek/at91sam9rlek.c | 29 ++++++++++ board/lwmon/lwmon.c | 29 ++++++++++ board/tqc/tqm8xx/tqm8xx.c | 26 +++++++++ common/lcd.c | 84 ++--------------------------- include/lcd.h | 2 + 8 files changed, 178 insertions(+), 79 deletions(-)
Jean-Christophe, you ACKed this patch in http://lists.denx.de/pipermail/u-boot/2008-October/042389.html.
Should it go through u-boot-video repository or do you intend to pick it up?
Note that it needs some fixes: s/CFG_MAX_NAND_DEVICE/CONFIG_SYS_MAX_NAND_DEVICE
Best regards, Anatolij