Subject: Re: [PATCH] imx9: Improve boot device auto-selection
On Wed, Oct 16, 2024 at 4:42 PM Szőke Benjamin egyszeregy@freemail.hu wrote:
You can use only one of config from CONFIG_ENV_IS_IN_MMC=y and CONFIG_ENV_IS_NOWHERE=y in U-boot config in same time.
imx93_11x11_evk_defconfig selects both CONFIG_ENV_IS_IN_MMC=y and CONFIG_ENV_IS_NOWHERE=y.
If you like to use CONFIG_ENV_IS_NOWHERE=y, these codes in the
patched
source files will be not part of the build, and the autodetection of the boot mode will never work. At the moment it works only if you
use
CONFIG_ENV_IS_IN_MMC=y in U-boot config but it should work also
in
case of use CONFIG_ENV_IS_NOWHERE=y option also.
But like I said imx93_11x11_evk_defconfig selects both CONFIG_ENV_IS_IN_MMC=y and CONFIG_ENV_IS_NOWHERE=y.
I am still confused by your patch.
I would like to get a feedback from Peng Fan.
In UUU boot mode, we use the env inside U-Boot proper, so it is NOWHERE.
In this patch, I think use changing to mmc for NOWHERE may break the rule.
Thanks, Peng.