Re: [U-Boot] [PATCH] serial: ns16550: fix different reg size access

Dear Lei Wen,

In message 1301586774-25447-1-git-send-email-leiwen@marvell.com you wrote:

Some hardware would dysfunctional if only access the register by byte. This patch is tend to recover original access the responding register according to CONFIG_SYS_NS16550_REG_SIZE.

Can you please explain on what board, and with which tool chain, you see any problems?

+- CONFIG_SYS_NS16550_MAX_REG_SIZE:

• Define the ns16550 max register size,
  

• if the CONFIG_SYS_NS16550_REG_SIZE is smaller than this value,
  

• use padding to fill those gap.
  

This makes no sense to me. A register is always one specific size, so the term "MAX_REG_SIZE" is bogus.

Best regards,

Wolfgang Denk