Re: [U-Boot] [PATCH 5/8] spi: Move mode, mode_rx, flags macro's to structure

Hi Jagan,

On Wed, Dec 16, 2015 at 11:40 PM, Jagan Teki jteki@openedev.com wrote:

This patch moves mode, mode_rx, flags macro's to respective member position on spi_slave{}, for better readabilty and finding the respective member macro's easily.

I am not in favor of mixing macros along with the structure members. This looks to me not clearer than before. Do we have some guideline anywhere?

This patch fix's the tab space on mode macro's as well.

Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com Cc: Michal Simek michal.simek@xilinx.com Cc: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Jagan Teki jteki@openedev.com

---

Regards, Bin