Re: [U-Boot-Users] [PATCH/review] Blackfin: protect default flash according to CFG_MONITOR_LEN

In message 1212298724-15152-2-git-send-email-vapier@gentoo.org you wrote:

As pointed out by Stefan Pledl, use the CFG_MONITOR_LEN define rather than assuming a 128kb region when setting up the default flash protection.

Signed-off-by: Mike Frysinger vapier@gentoo.org

lib_blackfin/board.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib_blackfin/board.c b/lib_blackfin/board.c index aae89d6..1a613c3 100644 --- a/lib_blackfin/board.c +++ b/lib_blackfin/board.c @@ -347,14 +347,13 @@ void board_init_r(gd_t * id, ulong dest_addr) #endif

#if !defined(CFG_NO_FLASH)

• /* There are some other pointer constants we must deal with */
• /* configure available FLASH banks */

• /* Initialize the flash and protect u-boot by default */ extern flash_info_t flash_info[];

• ulong size = flash_init(); puts("Flash: ");

• ulong size = flash_init();

Please do not declare variables in the middle of the code. We do not accept such a style in U-Boot.

Please fix and resubmit.

Best regards,

Wolfgang Denk