Re: [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter

Dear Simon Glass,

In message BANLkTinacFQ=1xA4PTgZKi5ON9AGG7-Jwg@mail.gmail.com you wrote:

...

...

+static void smsc95xx_halt(struct eth_device *eth) +{

• debug("** %s()\n", __func__);
  

+}

is this right ? shouldnt you be halting something ?

I could do, but halting is not in the driver at present. Do you think it is important?

Yes, it is important to shut down devices. Especially with USB devices.

BTW: can you *please* fix your mail addresses? It's not "Remy Bohmerl inux@bohmer.net" but "Remy Bohmer linux@bohmer.net" instead. Don't you get tons of bounce messages?

Best regards,

Wolfgang Denk