On Sat, 5 Jan 2019 at 10:01, Jagan Teki jagan@amarulasolutions.com wrote:
On Sat, Jan 5, 2019 at 7:27 AM Simon Glass sjg@chromium.org wrote:
Hi Jagan,
On Tue, 1 Jan 2019 at 12:17, Jagan Teki jagan@amarulasolutions.com wrote:
Migration plan for DM_SPI_FLASH is v2019.07 since it depends on DM_SPI migration.
Signed-off-by: Jagan Teki jagan@amarulasolutions.com
Changes for v2:
- none
Makefile | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/Makefile b/Makefile index c4d827f259..3e926d839f 100644 --- a/Makefile +++ b/Makefile @@ -964,6 +964,16 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy) @echo >&2 "See doc/driver-model/MIGRATION.txt for more info." @echo >&2 "====================================================" endif +endif +ifeq ($(CONFIG_SPI_FLASH),y)
Again i worry what happens if the board does not actually use SPI flash?
If SPI_FLASH not used then it will not enter this loop since its ifeq (not even to check next ifneq). Did you find any config to enter even if not used, same case for SPI.
OK I see.
Reviewed-by: Simon Glass sjg@chromium.org