On 06/20/2013 05:17 AM, Thierry Reding wrote:
On Thu, Jun 20, 2013 at 04:13:38PM +0800, Jim Lin wrote:
Add DT node for USB EHCI function. Add support for T30-Cardhu, T30-Beaver, T114-Dalmore boards.
Signed-off-by: Jim Lin jilin@nvidia.com --- Changes in v2: - Remove PLL parameters from dt file Changes in v3: - Change VBus GPIO from H.05 to DD.04 for Beaver board. Changes in v4: - Change Beaver VBus GPIO to H.05 and value to 0 for polarity to be High. I don't have Beaver board. So this needs somebody to help test. Thanks.
Why did you change it back to H.05 again? I already tested successfully that DD.04 is the right one.
Yes, such a change is clearly wrong. Jim, you have access to the schematics for all these boards. Please use them.
The correct values are:
Beaver:
USB1 VBUS: PEX_L1_CLKREQ / PDD6 / 238 USB3 VBUS: PEX_L1_PRSNT / PDD4 / 236
Incorrect: GMI_AD13 / PH5 / 61 (This is a signal that pulls up all of USB1 VBUS, USB3 VBUS, and GMI_AD15, which as far as I can tell is entirely unrelated to USB in any way)
Cardhu A04:
USB1 VBUS: PEX_L1_CLKREQ / PDD6 / 238 USB3 VBUS: PEX_L1_PRSNT / PDD4 / 236
Incorrect: PEX_L0_RST / PDD1 / 233 (This is a signal that pulls up a whole slew of signals, many of which are entirely unrelated to USB in any way)