I think I did send this mail to the old mail list
---------- Forwarded message ---------- From: Ricardo Ribalda Delgado ricardo.ribalda@uam.es Date: Tue, Aug 19, 2008 at 08:59 Subject: Re: [U-Boot-Users] [PATCH] (Resend)Allows negative offset in command loads To: Wolfgang Denk wd@denx.de Cc: u-boot@lists.denx.de
Hi Wolfgang:
Up to my knowledge, u-boot can load .bin, .elf and .srec binary files.
.bin files are just raw binaries with no location info. When you load this file the offset mean the "absolute address" .srec files have info about location. The offset really mean offset, and is relative to the address specified in the file .elf files have info about location, but right now (UTMK), u-boot does not support offsets.
I think that his patch is enough, other binaries should not be fixed because there is no reason to locate a .bin file in the address -0x234
What do you think?
Best regards
On Mon, Aug 18, 2008 at 18:02, Wolfgang Denk wd@denx.de wrote:
Dear Ricardo Ribalda Delgado,
In message 1217414369-28247-2-git-send-email-ricardo.ribalda@uam.es you wrote:
Signed-off-by: Ricardo Ribalda Delgado ricardo.ribalda@uam.es
I think it makes little sense to change only one command and leave the other, similar commands unchanged. All commands that provide similar functions should behave the same.
Previus commit had compiling warnings
common/cmd_load.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/common/cmd_load.c b/common/cmd_load.c index 1b75a7b..ae56543 100644 --- a/common/cmd_load.c +++ b/common/cmd_load.c @@ -38,7 +38,7 @@ static ulong load_serial_ymodem (ulong offset);
----------------------------------------------------^^^^^^^^^^^^^^
So this one should be changed, too?
Maybe others as well?
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "Pardon me for breathing, which I never do anyway so I don't know why I bother to say it, oh God, I'm so depressed. Here's another of those self-satisfied doors. Life! Don't talk to me about life." - Marvin the Paranoid Android
-- Ricardo Ribalda http://www.eps.uam.es/~rribalda/