Re: [RFC PATCH 06/10] cmd: add rpmsg framework commands

Hi Tanmay,

On Tue, 25 Jul 2023 at 08:08, Tanmay Shah tanmay.shah@amd.com wrote:

This patch introduces commands to use rpmsg framework

rpmsg init <core id>

• Initialize rpmsg framework for remote core

rpmsg debug_data <core id> <"tx" / "rx">

• debug tx or rx virtqueues. This command simply uses virtqueue_dump_data and prints virtqueue for rpmsg device mapped to <core id>

Signed-off-by: Tanmay Shah tanmay.shah@amd.com

MAINTAINERS | 1 + cmd/Kconfig | 6 +++++ cmd/Makefile | 1 + cmd/rpmsg.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++ include/rpmsg.h | 5 ++++ 5 files changed, 74 insertions(+) create mode 100644 cmd/rpmsg.c

Please add doc/usage/cmd file

as well as a test for your command in test/dm/rpmsg.c

You can see test/dm/acpi.c for an example.

Regards, Simon