Hi Priyanka,
-----Original Message----- From: Priyanka Jain priyanka.jain@nxp.com Sent: Tuesday, December 17, 2019 10:32 AM To: Kuldeep Singh kuldeep.singh@nxp.com; u-boot@lists.denx.de Cc: jagan@amarulasolutions.com; sr@denx.de; Ashish Kumar ashish.kumar@nxp.com; frieder.schrempf@kontron.de; Kuldeep Singh kuldeep.singh@nxp.com; Ashish Kumar ashish.kumar@nxp.com Subject: RE: [Patch v2 2/7] treewide: Remove unused FSL QSPI config options
-----Original Message----- From: Kuldeep Singh kuldeep.singh@nxp.com Sent: Monday, December 16, 2019 5:19 PM To: u-boot@lists.denx.de Cc: jagan@amarulasolutions.com; Priyanka Jain priyanka.jain@nxp.com; sr@denx.de; Ashish Kumar ashish.kumar@nxp.com; frieder.schrempf@kontron.de; Kuldeep Singh kuldeep.singh@nxp.com; Ashish Kumar ashish.kumar@nxp.com Subject: [Patch v2 2/7] treewide: Remove unused FSL QSPI config options
Some of these options are not used by the driver anymore and some of them are obsolete as the information is gathered from the dt. Also consolidating defines in common headers.
Signed-off-by: Frieder Schrempf frieder.schrempf@kontron.de Signed-off-by: Ashish Kumar Ashish.Kumar@nxp.com Signed-off-by: Kuldeep Singh kuldeep.singh@nxp.com
.../include/asm/arch-fsl-layerscape/config.h | 1 - arch/arm/include/asm/arch-ls102xa/config.h | 1 - include/configs/ls1012a_common.h | 17 +---------------- include/configs/ls1012afrwy.h | 3 --- include/configs/ls1012ardb.h | 3 --- include/configs/ls1021aiot.h | 6 ------ include/configs/ls1021aqds.h | 11 ----------- include/configs/ls1021atwr.h | 10 ---------- include/configs/ls1043aqds.h | 2 -- include/configs/ls1046afrwy.h | 9 --------- include/configs/ls1046aqds.h | 11 ----------- include/configs/ls1046ardb.h | 13 ------------- include/configs/ls1088a_common.h | 6 ------ include/configs/ls1088aqds.h | 8 -------- include/configs/ls1088ardb.h | 18 ------------------ include/configs/ls2080aqds.h | 2 -- include/configs/ls2080ardb.h | 8 ++------ include/configs/mx6sxsabreauto.h | 6 ------ include/configs/mx6sxsabresd.h | 11 ----------- include/configs/mx6ul_14x14_evk.h | 6 ------ include/configs/mx6ullevk.h | 6 ------ include/configs/mx7dsabresd.h | 8 -------- include/configs/pcm052.h | 7 ------- include/configs/vf610twr.h | 8 -------- scripts/config_whitelist.txt | 5 ----- 25 files changed, 3 insertions(+), 183 deletions(-)
diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h index a83c70ece2..913f7b179f 100644 --- a/arch/arm/include/asm/arch-fsl-layerscape/config.h +++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h @@ -304,7 +304,6 @@ #define CONFIG_SYS_FSL_ESDHC_BE #define CONFIG_SYS_FSL_WDOG_BE #define CONFIG_SYS_FSL_DSPI_BE -#define CONFIG_SYS_FSL_QSPI_BE #define CONFIG_SYS_FSL_CCSR_GUR_BE #define CONFIG_SYS_FSL_PEX_LUT_BE
diff --git a/arch/arm/include/asm/arch-ls102xa/config.h b/arch/arm/include/asm/arch-ls102xa/config.h index 970537870d..3884948a2c 100644 --- a/arch/arm/include/asm/arch-ls102xa/config.h +++ b/arch/arm/include/asm/arch-ls102xa/config.h @@ -94,7 +94,6 @@ #define CONFIG_SYS_FSL_ESDHC_BE #define CONFIG_SYS_FSL_WDOG_BE #define CONFIG_SYS_FSL_DSPI_BE -#define CONFIG_SYS_FSL_QSPI_BE #define CONFIG_SYS_FSL_DCU_BE #define CONFIG_SYS_FSL_SEC_MON_LE #define CONFIG_SYS_FSL_SFP_VER_3_2 diff --git a/include/configs/ls1012a_common.h b/include/configs/ls1012a_common.h index 2579e2fb37..efd0ee41b6 100644 --- a/include/configs/ls1012a_common.h +++ b/include/configs/ls1012a_common.h @@ -37,23 +37,8 @@ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128 * 1024)
/*SPI device */ -#if defined(CONFIG_QSPI_BOOT) || defined(CONFIG_TFABOOT) #define CONFIG_SYS_FMAN_FW_ADDR 0x400d0000 -#define CONFIG_SPI_FLASH_SPANSION
Please check order of patches. We are just removing configs in these patches, but adding the same in subsequent patches. Wont it break the system in between the series?
I am not sure of system breaking but it's better to move config CONFIG_SPI_FLASH_SPANSION from header to defconfigs in same patch. I'll update this in next version.
Thanks Kuldeep
<snip> -Priyanka