Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

30 Oct 2012


      Dear Lucas Stach,
[...]
...
...
...
-static int add_port(struct fdt_usb *config)
Fix the comment instead of removing it?
I don't think that this comment adds any real value. The whole function
which this comment refers to is removed and it's content split between
board_usb_init and ehci_hcd_init, which are self explanatory.
Then add a proper comment please. Call me a docu-nazi, but I'd really love u-
boot nicely and properly documented, please.
[1] http://www.denx.de/wiki/U-Boot/CodingStyle
Best regards,
Marek Vasut