Hi. Raymond.
I think you don't even need to change the order. The FW handoff must fulfill two conditions at the same time (A valid TL plus and proper register conventions). Both conditions are essential with the same priority and which one should be proceeded first is fully arbitrary.
okay. then I'll restore xferlist.c.
and send patch v3. Please ignore patch v2.
Thanks!
________________________________________ From: Raymond Mao raymond.mao@linaro.org Sent: 09 July 2024 20:26 To: Yeo Reum Yun Cc: trini@konsulko.com; sjg@chromium.org; ilias.apalodimas; n-jain1@ti.com; bmeng.cn@gmail.com; u-boot@lists.denx.de Subject: Re: [PATCH] bloblist: Fix bloblist convention checking.
Hi Levi,
On Tue, 9 Jul 2024 at 13:16, Yeo Reum Yun <YeoReum.Yun@arm.commailto:YeoReum.Yun@arm.com> wrote: Hi Raymond!
The handoff of armv7 will break if you swap arg[0] and arg[2] here. The args are already aligned in the correct order via the assembly code. Please see the 'save_boot_params' function in start.S of armv7.
Thanks to let me know. I couldn't see that code. But I think before checking transfer_list, It would be good to check convention first.
So, I'll change order only.
I think you don't even need to change the order. The FW handoff must fulfill two conditions at the same time (A valid TL plus and proper register conventions). Both conditions are essential with the same priority and which one should be proceeded first is fully arbitrary.
Regards, Raymond IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.