On 12/05/15 22:56, Tom Rini wrote:
On Tue, May 12, 2015 at 10:35:55PM +0200, Kamil Lulko wrote:
Strange, this was already posted by Kunhua Huang - then reverted in commit 698a12bef9e782dcd99c555a739c16eec8669f14. Anyway, yes this carriage return should be added there. I simply forgot it since I had implicit CR for each LF turned on in my terminal. Never thought this would cause so much havoc for users ;)
I reverted it since the author said it wasn't needed with the other patch they did being applied. Daniel, can you confirm the odd behavior exists with top of tree? Thanks!
Yes, the odd behavior still exists with top of tree.
That said, I lucked out here.
In truth I had the problem because my git tree was slightly more out of date than I thought it was (and because a google search for "serial u-boot stm32" before posting my patch didn't notice the code from Kunhua).
So... my patch won't apply to HEAD anyway but reverting the revert would be very welcome!
Daniel.