Re: [U-Boot] [PATCH 1/2] gpio: add gpio api support to mx27 (v3)

Hi Stefano,

+    u32 gpio_dr; /* DR */ +    u32 gius; +    u32 ssr;

What about my proposal to change this into gpio_psr ? I mean, if Freescale calls some times the register "Sample Status Register" and on other SOCs "Pad Status Register", but anyway the register does the same, it is not a good reason to follow it.

I think you're right, sorry, I read your feedback too fast and missed this one. I update my patch and send a v4.

+#ifndef CONFIG_MX27       val = (readl(&regs->gpio_psr) >> gpio) & 0x01; +#else +    val = (readl(&regs->ssr) >> gpio) & 0x01; +#endif

Not required if ssr becomes gpio_psr

I agree too.

Regards, Philippe