Dear Stefan Schmidt,
Nice stuff, can you CC me when it comes to USB stuff, accidentally I became the new maintainer ? ;-)
drivers/usb/gadget/dfu.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/dfu.c b/drivers/usb/gadget/dfu.c index 535e194..7aed344 100644 --- a/drivers/usb/gadget/dfu.c +++ b/drivers/usb/gadget/dfu.c @@ -47,6 +47,10 @@ #include <malloc.h> #include "dfu.h"
+#ifndef POLL_TIMEOUT_MILLISECONDS +#define POLL_TIMEOUT_MILLISECONDS 5 +#endif
static struct flash_entity *flash_ents; static int num_flash_ents;
@@ -271,9 +275,14 @@ static void handle_getstatus(struct usb_request *req)
/* send status response */ dstat->bStatus = dev->dfu_status;
- /* FIXME: set dstat->bwPollTimeout */ dstat->bState = dev->dfu_state; dstat->iString = 0;
- /* FIXME: Use real values from flash subsystem here instead a hardcoded
* value */- dstat->bwPollTimeout[0] = POLL_TIMEOUT_MILLISECONDS & 0xff;
- dstat->bwPollTimeout[1] = (POLL_TIMEOUT_MILLISECONDS >> 8) & 0xff;
- dstat->bwPollTimeout[2] = (POLL_TIMEOUT_MILLISECONDS >> 16) & 0xff;
- //req->actual = MIN(sizeof(*dstat), max);
What do you expect from me to tell you about this patch? Or do you expect someone else to comment on this?
}
static void handle_getstate(struct usb_request *req)
Best regards, Marek Vasut