Hi Albert,
On 3 February 2015 at 10:13, Albert ARIBAUD (3ADEV) albert.aribaud@3adev.fr wrote:
This patch extends OMAP3 support for AM/DM37xx and introduces the AM3703-based Quipos Cairo board.
Signed-off-by: Albert ARIBAUD (3ADEV) albert.aribaud@3adev.fr
NOTES:
Two checkpatch diagnostics are left uncorrected:
"warning: arch/arm/cpu/armv7/omap3/Kconfig,94: please write a paragraph that describes the config symbol fully" No other symbol of the same nature has such a paragraph, so I left it out.
"check: board/quipos/cairo/cairo.c,87: Avoid CamelCase: <SDP_3430_SDRC_RFR_CTRL_165MHz>" Symbol was not defined in this patch. If requested, I will post a separate change to fix the symbol.
Changes in v2:
- removed v1 patches 1..5 applied to mainline
- corrected serial device name from ttyS1 to ttyO1
- rewrote config file based on omap3_beagle's
- moved serial support to DM
- fixed environment
Reviewed-by: Simon Glass sjg@chromium.org
I would argue for device tree support instead of platform data, but I'm not sure if this platform has that so will reserve judgement.
Regards, Simon