On Sat, 27 Jun 2020 at 07:10, Bin Meng bmeng.cn@gmail.com wrote:
+Simon,
On Sat, Jun 27, 2020 at 8:00 PM Tom Rini trini@konsulko.com wrote:
In the future if we have separate symbols for DM_SPI_FLASH and SPL_DM_SPI_FLASH we will not always have function declarations available for some DM calls. This in turn leads to build warnings but not failures as the code isn't used and is discarded at link time. Restructure things to not build code we won't use for TPL anyways.
Cc: Bin Meng bmeng.cn@gmail.com Signed-off-by: Tom Rini trini@konsulko.com
I ran in to this as part of testing http://patchwork.ozlabs.org/project/uboot/patch/20200604151153.3980-4-Zhiqia... which we do need to bring in. I think we might be building a lot of codde that's then discarded for TPL builds, but didn't think this is the right place to tackle that in.
Yes we build far too much with TPL at present I think.
arch/x86/cpu/apollolake/Makefile | 2 +- arch/x86/lib/Makefile | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
Reviewed-by: Simon Glass sjg@chromium.org