On Thu, Jan 06, 2022 at 09:10:00AM -0800, Tim Harvey wrote:
On Thu, Jan 6, 2022 at 2:07 AM ZHIZHIKIN Andrey andrey.zhizhikin@leica-geosystems.com wrote:
Hello Tim,
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Tim Harvey Sent: Wednesday, January 5, 2022 8:08 PM To: ZHIZHIKIN Andrey andrey.zhizhikin@leica-geosystems.com Cc: u-boot u-boot@lists.denx.de; Stefano Babic sbabic@denx.de; Fabio Estevam festevam@gmail.com; Schrempf Frieder frieder.schrempf@kontron.de; Adam Ford aford173@gmail.com; Marcel Ziswiler marcel@ziswiler.com; Jagan Teki jagan@amarulasolutions.com Subject: Re: mkimage_fit_atf.sh: not found
On Wed, Jan 5, 2022 at 3:34 AM ZHIZHIKIN Andrey andrey.zhizhikin@leica-geosystems.com wrote:
Hello Tim,
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Tim Harvey Sent: Tuesday, January 4, 2022 11:48 PM To: u-boot u-boot@lists.denx.de; Stefano Babic sbabic@denx.de; Fabio
Estevam
festevam@gmail.com Cc: Schrempf Frieder frieder.schrempf@kontron.de; Adam Ford aford173@gmail.com; Marcel Ziswiler marcel@ziswiler.com; Jagan Teki jagan@amarulasolutions.com Subject: mkimage_fit_atf.sh: not found
Stefano and Fabio,
I'm seeing the imx8mm_venice_defconfig target failing to build on master due to mkimage_fit_atf.sh not found: ./"arch/arm/mach-imx/mkimage_fit_atf.sh" \ arch/arm/dts/imx8mm-venice-gw71xx-0x.dtb arch/arm/dts/imx8mm-venice-gw72xx-0x.dtb arch/arm/dts/imx8mm-venice-gw73xx-0x.dtb arch/arm/dts/imx8mm-venice-gw7901.dtb arch/arm/dts/imx8mm-venice-gw7902.dtb > u-boot.its /bin/sh: 1: ./arch/arm/mach-imx/mkimage_fit_atf.sh: not found
This has been dropped in d9a6f0eed6 ("tree: imx: remove old fit generator
script")
So why was that merged when it breaks several boards that are not switched to binman because of the CI issue?
Because the FIT generator script has been broken after commit 3f04db891a ("image: Check for unit addresses in FITs"), which has covered CVE-2021-27138. You can see the reasoning of merging d9a6f0eed6 ("tree: imx: remove old fit generator script") in the commit message.
In addition, d9a6f0eed6 ("tree: imx: remove old fit generator script") has been introduced as a part of discussion stemmed from [1], where it has been pointed out that certain boards are still using old FIT generator which is not working, and I've listed those board config files for maintainers to react.
Andrey,
I agree removing the old fit generator is the right path but I am very surprised it was merged when it broke boards that had not moved to binman yet. There has been a warning to migrate to binman but there was never a deadline.
Binman CI missing binaries verification came later I believe, that is the reason we are seeing those conversions pending. But this is unrelated to the FIT generator script removal, which was broken anyways.
I have not followed the discussion about what was wrong with the FIT generator or what was specifically 'broken' but boards at least built and booted with it and now they do not build. I do know there was a time where I needed a patch that dealt with '@' symbols and I'm not sure if that ever got merged before the FIT generator was simply removed. Again, I hadn't thought much of it because I had binman conversion patches in flight not realizing they would get stuck because of CI.
I don't really know anything about U-Boot CI but I'm also surprised it doesn't point out the fact that several boards won't currently build.
Note that all boards currently _do_ build because whatever is missing today isn't part of the "all" target. This is likely because there's a few build targets that rely on some CONFIG options that in turn are not part of Kconfig and so don't always work.
[snip]
I don't know exactly how the U-Boot release schedule works and when 2021.01 is released but in order to save these boards from being broken the following would have to occur:
I guess https://www.denx.de/wiki/U-Boot/ReleaseCycle needs to be more widely publicized?
apply Heiko's [PATCH v4] binman: add support for creating dummy files for external blobs (https://patchwork.ozlabs.org/project/uboot/list/?series=279595) apply the conversion to binman series that has been pending because of the CI breakage for these boards:
- Adam Ford: imx8mm_beacon* boards
- Tim Harvey: imx8mm_venice boards
- Andrey Zhizhikin: imx8mq_evk
- Peng Fan: imx8mq_phanbell and pico-imx8mq
That would still leave the following boards broken as nobody has submitted binman patches for them. These are both maintained by Oliver Graute (added to cc): imx8qm_rom7720_a1_4G_defconfig cgtqmx8_defconfig
I believe Stefano is not currently available and I'm not sure when he is back to merge the pending binman conversion series. Additionally some of these series may need to be rebased (I know I had to do that twice because of things being moved to Kconfig)
I'm doing one last test of reverting d9a6f0eed6 which should also restore functionality for now, yes?