Series https://patchwork.ozlabs.org/project/uboot/list/?series=421417 Add Starfive JH7110 Cadence USB driver fails to compile anymore without this patch.
With that,
Tested-by: E Shattow <lucent@gmail.com
On Sun, Jul 28, 2024 at 10:47 PM Maxim Kochetkov fido_max@inbox.ru wrote:
27.07.2024 13:35, E Shattow wrote:
Is this a problem in Linux upstream? or specific to U-Boot, and is it a regression?
refrerence https://lore.kernel.org/u-boot/20240504183354.GL2568172@bill-the-cat/ and reference https://lore.kernel.org/u-boot/BJXPR01MB0855813DD38EF86CCA6DD5C8E6E92@BJXPR0...
It is very similar. But it comes from
In file included from /home/maximus/git/yadro/ymp-build/u-boot/include/linux/usb/composite.h:26, from /home/maximus/git/yadro/ymp-build/u-boot/include/g_dnl.h:12, from /home/maximus/git/yadro/ymp-build/u-boot/cmd/fastboot.c:12: /home/maximus/git/yadro/ymp-build/u-boot/include/linux/bitmap.h: In function ‘bitmap_find_next_zero_area’: /home/maximus/git/yadro/ymp-build/u-boot/include/linux/bitmap.h:170:17: error: implicit declaration of function ‘find_next_zero_bit’; did you mean ‘find_next_bit’? [-Wimplicit-function-declaration] 170 | index = find_next_zero_bit(map, size, start); | ^~~~~~~~~~~~~~~~~~ | find_next_bit
I've just tried v2024.07 and master.
I tried to drop #include <linux/bitmap.h> from composite.h, but it fails on usb gadget compilation:
CC drivers/usb/gadget/g_dnl.o In file included from /home/maximus/git/yadro/ymp-build/u-boot/drivers/usb/gadget/g_dnl.c:24: /home/maximus/git/yadro/ymp-build/u-boot/drivers/usb/gadget/composite.c: In function ‘reset_config’: /home/maximus/git/yadro/ymp-build/u-boot/drivers/usb/gadget/composite.c:362:17: error: implicit declaration of function ‘bitmap_zero’ [-Wimplicit-function-declaration] 362 | bitmap_zero(f->endpoints, 32); | ^~~~~~~~~~~