-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: vendredi 21 juillet 2017 17:20 To: Patrice CHOTARD patrice.chotard@st.com; Bin Meng bmeng.cn@gmail.com Cc: Patrick DELAUNAY patrick.delaunay@st.com; u-boot@lists.denx.de; ran.wang_1@nxp.com; Jean-Jacques Hiblot jjhiblot@ti.com; Christophe KERELLO christophe.kerello@st.com; Simon Glass sjg@chromium.org; Masahiro Yamada yamada.masahiro@socionext.com; Konstantin Porotchkin kostap@marvell.com; Philipp Tomsich philipp.tomsich@theobroma-systems.com; Uri Mashiach uri.mashiach@compulab.co.il; Stefan Roese sr@denx.de Subject: Re: [PATCH] usb: add dependency with generic PHY support Importance: High
On 07/21/2017 05:18 PM, Patrice CHOTARD wrote:
Hi All
On 07/21/2017 04:57 PM, Marek Vasut wrote:
On 07/21/2017 04:54 PM, Bin Meng wrote:
Hi Marek,
On Fri, Jul 21, 2017 at 9:31 PM, Marek Vasut marex@denx.de wrote:
On 07/21/2017 03:09 PM, Patrick DELAUNAY wrote:
> -----Original Message----- > From: Marek Vasut [mailto:marex@denx.de] > Sent: vendredi 21 juillet 2017 14:54 > To: Patrick DELAUNAY patrick.delaunay@st.com; > u-boot@lists.denx.de > Cc: Patrice CHOTARD patrice.chotard@st.com;
ran.wang_1@nxp.com;
> Jean-Jacques Hiblot jjhiblot@ti.com; Christophe KERELLO > christophe.kerello@st.com; Simon Glass sjg@chromium.org; > Masahiro Yamada yamada.masahiro@socionext.com; Konstantin > Porotchkin kostap@marvell.com; Bin Meng
> Philipp Tomsich philipp.tomsich@theobroma-systems.com; Uri > Mashiach uri.mashiach@compulab.co.il; Stefan Roese
> Subject: Re: [PATCH] usb: add dependency with generic PHY support > Importance: High > > On 07/21/2017 02:50 PM, Patrick Delaunay wrote: >> select CONFIG_PHY when phy is used in driver >> - USB_EHCI_GENERIC >> - USB_OHCI_GENERIC >> - USB_XHCI_DWC3 > > Why would I want PHY enabled on boards which do not use PHY > framework at all ? I have boards with EHCI, which do not use PHY > framework, so this just adds bloat IMO.
Just to avoid compilation issue if you don't have compilation flag in driver or in PHY header (replace by no-obs phy)
But perhaps I misunderstanding the conclusion for [PATCH 1/1] dm: phy: add missing #ifdef CONFIG_PHY
=> NOOPS phy is added => And the Patrice patch is dropped !?
But in fact if the last Patrice patch is accepted, the stub for phy is added directly in .h file and compilation issues are solved. So you can forget my patch and sorry for disturbance.
I'm a little lost myself, a bit of coordination between you, Patrice and Bin would not hurt.
Sorry I don't know what coordination I could help. I think Patrice provided a patch that fixed the broken build, but Patrick created another patch to fix the same problem?
Yes, and there's the third NOP PHY patch. I'm sure we need the NOP PHY patch and there'll be a V2 of that. But I think we need some more patches to fix the build (?)
Unfortunately i am not sure to get time to release the fix before the week end, but i will work on that issue on Monday.
Good enough for me.
Thanks Patrice,
This patch is no more needed with http://patchwork.ozlabs.org/patch/792712/
And I change the state to Rejected
Patrick
-- Best regards, Marek Vasut