Re: [U-Boot] [PATCH v2 6/6] MIPS: add BMIPS Comtrend CT-5361 board

On 15 May 2017 at 11:13, Álvaro Fernández Rojas noltari@gmail.com wrote:

Signed-off-by: Álvaro Fernández Rojas noltari@gmail.com

v2: add comtrend ct-5361 Kconfig

arch/mips/dts/Makefile | 1 + arch/mips/dts/comtrend,ct-5361.dts | 49 ++++++++++++++++++++++++++++++ arch/mips/mach-bmips/Kconfig | 6 ++++ board/comtrend/ct5361/Kconfig | 12 ++++++++ board/comtrend/ct5361/MAINTAINERS | 6 ++++ board/comtrend/ct5361/Makefile | 5 +++ board/comtrend/ct5361/ct-5361.c | 7 +++++ configs/comtrend_ct5361_ram_defconfig | 57 +++++++++++++++++++++++++++++++++++ include/configs/comtrend_ct5361.h | 20 ++++++++++++ 9 files changed, 163 insertions(+) create mode 100644 arch/mips/dts/comtrend,ct-5361.dts create mode 100644 board/comtrend/ct5361/Kconfig create mode 100644 board/comtrend/ct5361/MAINTAINERS create mode 100644 board/comtrend/ct5361/Makefile create mode 100644 board/comtrend/ct5361/ct-5361.c create mode 100644 configs/comtrend_ct5361_ram_defconfig create mode 100644 include/configs/comtrend_ct5361.h

Reviewed-by: Simon Glass sjg@chromium.org

Please see below.

diff --git a/arch/mips/dts/Makefile b/arch/mips/dts/Makefile index 4c02c48..9bab744 100644 --- a/arch/mips/dts/Makefile +++ b/arch/mips/dts/Makefile @@ -9,6 +9,7 @@ dtb-$(CONFIG_TARGET_MALTA) += mti,malta.dtb dtb-$(CONFIG_TARGET_PIC32MZDASK) += pic32mzda_sk.dtb dtb-$(CONFIG_TARGET_XILFPGA) += nexys4ddr.dtb dtb-$(CONFIG_BOARD_COMTREND_AR5387UN) += comtrend,ar-5387un.dtb +dtb-$(CONFIG_BOARD_COMTREND_CT5361) += comtrend,ct-5361.dtb dtb-$(CONFIG_BOARD_COMTREND_VR3032U) += comtrend,vr-3032u.dtb dtb-$(CONFIG_BOARD_HUAWEI_HG556A) += huawei,hg556a.dtb dtb-$(CONFIG_BOARD_TPLINK_WDR4300) += tplink_wdr4300.dtb diff --git a/arch/mips/dts/comtrend,ct-5361.dts b/arch/mips/dts/comtrend,ct-5361.dts new file mode 100644 index 0000000..c909a52 --- /dev/null +++ b/arch/mips/dts/comtrend,ct-5361.dts @@ -0,0 +1,49 @@ +/*

• • Copyright (C) 2017 Álvaro Fernández Rojas noltari@gmail.com
• • SPDX-License-Identifier: GPL-2.0+
• */

+/dts-v1/;

+#include "brcm,bcm6348.dtsi"

+/ {

•   model = "Comtrend CT-5361";
  

•   compatible = "comtrend,ct-5361", "brcm,bcm6348";
  

•   aliases {
  

•           serial0 = &uart0;
  

•   };
  

•   chosen {
  

•           stdout-path = "serial0:115200n8";
  

•   };
  

•   gpio-leds {
  

•           compatible = "gpio-leds";
  

•           power_green {
  

•                   label = "CT-5361:green:power";
  

•                   gpios = <&gpio0 0 1>;
  

•           };
  

•           alarm_red {
  

•                   label = "CT-5361:red:alarm";
  

•                   gpios = <&gpio0 2 1>;
  

•           };
  

•   };
  

+};

+&gpio0 {

•   status = "okay";
  

+};

+&pflash {

•   status = "okay";
  

+};

+&uart0 {

•   u-boot,dm-pre-reloc;
  

•   status = "okay";
  

+}; diff --git a/arch/mips/mach-bmips/Kconfig b/arch/mips/mach-bmips/Kconfig index b7f7b1e..c2b0f89 100644 --- a/arch/mips/mach-bmips/Kconfig +++ b/arch/mips/mach-bmips/Kconfig @@ -65,6 +65,11 @@ config BOARD_COMTREND_AR5387UN depends on SOC_BMIPS_BCM6328 select BMIPS_SUPPORTS_BOOT_RAM

+config BOARD_COMTREND_CT5361

•   bool "Comtrend CT-5361"
  

•   depends on SOC_BMIPS_BCM6348
  

•   select BMIPS_SUPPORTS_BOOT_RAM
  

It would be good to add a paragraph describing each of these boards, peripherals, etc.