Hi Marek,
On Fri, 2015-11-20 at 21:48 +0100, Marek Vasut wrote:
On Wednesday, November 18, 2015 at 04:26:21 PM, Alexey Brodkin wrote:
This driver is meant to be used with any EHCI-compatible host controller in case if there's no need for platform-specific glue such as setup of controller or PHY's power mode via GPIOs etc.
Signed-off-by: Alexey Brodkin abrodkin@synopsys.com Reviewed-by: Simon Glass sjg@chromium.org Reviewed-by: Marek Vasut marex@denx.de Cc: Stephen Warren swarren@nvidia.com
Changes compared to v1:
- Updated commit message with removal of Synopsys board mention
- Cleaned-up ehci_usb_remove()
[...]
+static int ehci_usb_probe(struct udevice *dev) +{
- struct ehci_hccr *hccr = (struct ehci_hccr *)dev_get_addr(dev);
- struct ehci_hcor *hcor;
- hcor = (struct ehci_hcor *)((uint32_t)hccr +
This should be uintptr_t for the sake of 64bit systems, no ?
Hm, that's a good point! Indeed I was only thinking about 32-bit systems that I work with. So please do that change.
What's interesting most of other USB drivers do use "uint32_t" so there's a room for improvement it seems :)
-Alexey